cloud-fan commented on a change in pull request #26615: [SPARK-29977][SQL]
Remove newMutableProjection/newOrdering/newNaturalAscendingOrdering from
SparkPlan
URL: https://github.com/apache/spark/pull/26615#discussion_r348916674
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/SortAggregateExec.scala
##########
@@ -93,7 +93,7 @@ case class SortAggregateExec(
initialInputBufferOffset,
resultExpressions,
(expressions, inputSchema) =>
- newMutableProjection(expressions, inputSchema,
subexpressionEliminationEnabled),
+ MutableProjection.create(expressions, inputSchema),
Review comment:
Seems the new code path always set `subexpressionEliminationEnabled` to
false. Can we provide a `create` method that takes
`subexpressionEliminationEnabled` parameter?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
