yaooqinn commented on a change in pull request #26622: [WIP][SPARK-28023][Test] Cheap UTF8String Trim URL: https://github.com/apache/spark/pull/26622#discussion_r348920168
########## File path: sql/core/benchmarks/CastBenchmark-results.txt ########## @@ -6,7 +6,7 @@ Java HotSpot(TM) 64-Bit Server VM 1.8.0_231-b11 on Mac OS X 10.15.1 Intel(R) Core(TM) i5-5287U CPU @ 2.90GHz Benchmark trim the string: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative ------------------------------------------------------------------------------------------------------------------------ -cast(str as int) as c_int 3169 3530 610 1.3 773.6 1.0X -cast(str as long) as c_long 1812 1881 60 2.3 442.4 1.7X +cast(str as int) as c_int 2208 4341 1848 1.9 539.0 1.0X +cast(str as long) as c_long 2039 3450 2146 2.0 497.8 1.1X Review comment: @cloud-fan the result seems not as we expected, I'd increase the cardinality and do another test round. Can you help me to see if I missed something? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
