Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/4370#discussion_r24277121
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -231,6 +231,17 @@ private[history] class FsHistoryProvider(conf:
SparkConf) extends ApplicationHis
}
/**
+ * Comparison function that defines the sort order for the application
listing.
+ *
+ * @return Whether `i1` should precede `i2`.
+ */
+ private def compareAppInfo(
+ i1: FsApplicationHistoryInfo,
+ i2: FsApplicationHistoryInfo): Boolean = {
+ if (i1.endTime != i2.endTime) i1.endTime >= i2.endTime else
i1.startTime >= i2.startTime
--- End diff --
I don't imagine it probably matters, but this should be `>` instead of `>=`
I think? or else this says that two equal intervals should both precede the
other. I bet it doesn't make the sort wrong, just might affect whether the sort
is stable, but who cares here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
