uncleGen commented on a change in pull request #26610: [SPARK-29973][SS] Make 
`processedRowsPerSecond` calculated more accurately and meaningfully
URL: https://github.com/apache/spark/pull/26610#discussion_r348940685
 
 

 ##########
 File path: 
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingQueryStatusAndProgressSuite.scala
 ##########
 @@ -215,6 +218,60 @@ class StreamingQueryStatusAndProgressSuite extends 
StreamTest with Eventually {
     }
   }
 
+  test("SPARK-29973: Make `processedRowsPerSecond` calculated more accurately 
and meaningfully") {
 
 Review comment:
   - The latest commit is `50baee9` and it fails PySpark unit tests. I think it 
is irrelevant. 
   - In this test, the batch will end with same time with batch begin. And it 
test the  actual change.
   - The change in PR is explicit, and there may not be a need to add UT. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to