peter-toth edited a comment on issue #26044: [SPARK-29375][SQL] Exchange reuse across all subquery levels URL: https://github.com/apache/spark/pull/26044#issuecomment-552225930 > Could you show us actual performance numbers with/without this pr? I created a simple benchmark here: https://github.com/peter-toth/spark/commit/24cfee8001ac4f47351c6a2aa5a80a0198fd19f6 just to show that this PR (`originalReuseExchangeVersion - false`) makes sense in some cases. ``` OpenJDK 64-Bit Server VM 1.8.0_212-b04 on Mac OS X 10.14.6 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz Exchange reuse 1: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative ------------------------------------------------------------------------------------------------------------------------ originalReuseExchangeVersion - true 17409 17490 114 0.0 3481886067.0 1.0X originalReuseExchangeVersion - false 6889 6907 26 0.0 1377804241.4 2.5X OpenJDK 64-Bit Server VM 1.8.0_212-b04 on Mac OS X 10.14.6 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz Exchange reuse 2: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative ------------------------------------------------------------------------------------------------------------------------ originalReuseExchangeVersion - true 17279 17323 63 0.0 3455745161.4 1.0X originalReuseExchangeVersion - false 7126 7177 72 0.0 1425193388.2 2.4X ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
