peter-toth commented on a change in pull request #26044: [SPARK-29375][SQL]
Exchange reuse across all subquery levels
URL: https://github.com/apache/spark/pull/26044#discussion_r349190793
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
##########
@@ -93,11 +93,13 @@ case class HashAggregateExec(
// This is for testing. We force TungstenAggregationIterator to fall back to
the unsafe row hash
// map and/or the sort-based aggregation once it has processed a given
number of input rows.
private val testFallbackStartsAt: Option[(Int, Int)] = {
- sqlContext.getConf("spark.sql.TungstenAggregate.testFallbackStartsAt",
null) match {
- case null | "" => None
- case fallbackStartsAt =>
- val splits = fallbackStartsAt.split(",").map(_.trim)
- Some((splits.head.toInt, splits.last.toInt))
+ Option(sqlContext).flatMap {
Review comment:
`InSubqueryExec` already has `lazy val canonicalized` defined so maybe this
issue could come up without this PR in some DPP usecases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
