vanzin edited a comment on issue #26609: [SPARK-29971] Fix multiple possible buffer leaks in `TransportFrameDecoder/TransportCipher` URL: https://github.com/apache/spark/pull/26609#issuecomment-557203709 Still not following you. `feedData` is called once in `channelRead`, and the contract in the code is that all that buffer's data must be read in that same call to `channelRead`. So you can release the buffer in `channelRead` just fine as far as I can see. `close` doesn't need to do anything. (You need to release the buffer in `channelRead` in any case, don't you? Since `close` is not called for each call to `channelRead`).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
