liancheng commented on a change in pull request #26619: [SPARK-29981][BUILD]
Add hive-1.2/2.3 profiles
URL: https://github.com/apache/spark/pull/26619#discussion_r349326090
##########
File path: pom.xml
##########
@@ -128,19 +128,19 @@
<zookeeper.version>3.4.14</zookeeper.version>
<curator.version>2.7.1</curator.version>
<okapi.version>0.4.2</okapi.version>
- <hive.group>org.spark-project.hive</hive.group>
- <hive.classifier></hive.classifier>
+ <hive.group>org.apache.hive</hive.group>
+ <hive.classifier>core</hive.classifier>
<!-- Version used in Maven Hive dependency -->
- <hive.version>1.2.1.spark2</hive.version>
+ <hive.version>2.3.6</hive.version>
<hive23.version>2.3.6</hive23.version>
<!-- Version used for internal directory structure -->
- <hive.version.short>1.2.1</hive.version.short>
+ <hive.version.short>2.3.5</hive.version.short>
Review comment:
BTW, any reason why we needed the patch version in the directory names
initially? I don't think we need different shims for Hive patch versions. If
that's true, I'd suggest renaming the `sql/hive-thriftserver/{v1.2.1,v2.3.5}`
folders to just `v1.2` and `v2.3`. Of course, this can be done in a follow-up
PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
