Ngone51 commented on a change in pull request #26472: [SPARK-29838][SQL]
PostgreSQL dialect: cast to timestamp
URL: https://github.com/apache/spark/pull/26472#discussion_r349417251
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/PostgreSQLDialect.scala
##########
@@ -46,4 +46,19 @@ object PostgreSQLDialect {
}
}
}
+
+ object CastToTimestamp extends Rule[LogicalPlan] {
+ override def apply(plan: LogicalPlan): LogicalPlan = {
+ val conf = SQLConf.get
+ if (conf.usePostgreSQLDialect) {
+ plan.transformExpressions {
+ case Cast(child, dataType, timeZoneId)
+ if dataType == TimestampType =>
Review comment:
Oh, sorry. Here, I mean that we should change the if condition to: `if
child.dataType != TimestampType && dataType == TimestampType && =>`. Because
`Optimizer`, currently, can not optimize Pg cast.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
