viirya commented on a change in pull request #26512: [WIP][SPARK-29493][SQL]
Arrow MapType support
URL: https://github.com/apache/spark/pull/26512#discussion_r349449391
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/util/ArrowUtils.scala
##########
@@ -88,6 +90,16 @@ object ArrowUtils {
fields.map { field =>
toArrowField(field.name, field.dataType, field.nullable,
timeZoneId)
}.toSeq.asJava)
+ case MapType(keyType, valueType, valueContainsNull) =>
+ val mapType = new FieldType(valueContainsNull, new
ArrowType.Map(false), null)
Review comment:
`valueContainsNull` is for map values have null or not. For FieldType here,
I think it is like ArrayType and StructType cases, we should use given nullable
parameter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
