MaxGekk commented on issue #26473: [SPARK-29864][SPARK-29920][SQL] Strict parsing of day-time strings to intervals URL: https://github.com/apache/spark/pull/26473#issuecomment-557581667 > @MaxGekk do we have a simple example to demonstrate the bug of ThriftServerQueryTestSuite? If this PR will be merged to the master, the bug can be reproduced by removing `set ...` in `ansi/interval.sql` pretty easy. Otherwise I don't know how to reproduce it easier. > We can create a JIRA to look into it. It has been already created: https://issues.apache.org/jira/browse/SPARK-29933 > In the meanwhile, we don't add tests to pgsql/interval.sql to avoid the bug. Actually, it is not enough because wrong settings cause failure `ansi/interval.sql` due to https://issues.apache.org/jira/browse/SPARK-29920 and `postgresql/interval.sql` due to `ThriftServerQueryTestSuite` uses new implementation which is much stronger. I could remove the tests from `*interval.sql` but I would prefer to leave them there to have reproducible examples for [SPARK-29933 ](https://issues.apache.org/jira/browse/SPARK-29933) and to don't forget about the test in the future.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
