vanzin commented on a change in pull request #26508: [SPARK-26260][Core]For
disk store tasks summary table should show only successful tasks summary
URL: https://github.com/apache/spark/pull/26508#discussion_r349836714
##########
File path: core/src/main/scala/org/apache/spark/status/storeTypes.scala
##########
@@ -177,6 +177,10 @@ private[spark] class TaskDataWrapper(
val accumulatorUpdates: Seq[AccumulableInfo],
val errorMessage: Option[String],
+ // Non successful metrics now will have negative values in
`TaskDataWrapper`.
Review comment:
This comment seems a little bit out of place. It sounds better when merged
with the comment just below the `hasMetrics` field, which also needs to be
updated anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
