shahidki commented on a change in pull request #26378:
[SPARK-29724][SPARK-29726][WEBUI][SQL] Support JDBC/ODBC tab for HistoryServer
WebUI
URL: https://github.com/apache/spark/pull/26378#discussion_r349889721
##########
File path:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/ui/ThriftServerSessionPage.scala
##########
@@ -31,18 +31,16 @@ import org.apache.spark.util.Utils
/** Page for Spark Web UI that shows statistics of jobs running in the thrift
server */
private[ui] class ThriftServerSessionPage(parent: ThriftServerTab)
extends WebUIPage("session") with Logging {
-
- private val listener = parent.listener
- private val startTime = Calendar.getInstance().getTime()
+ val store = parent.store
+ private val startTime = parent.startTime
/** Render the page */
def render(request: HttpServletRequest): Seq[Node] = {
val parameterId = request.getParameter("id")
require(parameterId != null && parameterId.nonEmpty, "Missing id
parameter")
- val content =
- listener.synchronized { // make sure all parts in this page are
consistent
- val sessionStat = listener.getSession(parameterId).getOrElse(null)
+ val content = { // make sure all parts in this page are consistent
Review comment:
I will check this, I think the inconsistency problem doesn't occur
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
