dongjoon-hyun commented on a change in pull request #21668: [SPARK-24690][SQL]
Add a config to control plan stats computation in LogicalRelation
URL: https://github.com/apache/spark/pull/21668#discussion_r349900726
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
##########
@@ -634,7 +634,7 @@ case class HiveTableRelation(
)
override def computeStats(): Statistics = {
- tableMeta.stats.map(_.toPlanStats(output, conf.cboEnabled))
+ tableMeta.stats.map(_.toPlanStats(output, conf.planStatsEnabled))
Review comment:
Oh, @maropu . I'm wondering if the following is better. If someone already
is `cboEnabled=true`, this will protect the potential regression due to the new
option because the new default value of new option is `false`. How do you think
about that?
```scala
- tableMeta.stats.map(_.toPlanStats(output, conf.planStatsEnabled))
+ tableMeta.stats.map(_.toPlanStats(output, conf.cboEnabled ||
conf.planStatsEnabled))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
