dilipbiswal commented on issue #26635: [SPARK-28812][SQL][DOC] Document SHOW PARTITIONS in SQL Reference URL: https://github.com/apache/spark/pull/26635#issuecomment-557855975 @dongjoon-hyun Thank you very much. May i please request you to put some thoughts on how we should standardize on specifying table identifiers and partition specifications in the sql reference doc ? For table identifiers, we have used a few variations that i see in our doc. 1) [db_name].table_name in main syntax block. 2) table_name in the main syntax block and a parameter table_name. In this case, we don't seem to specify that it is an table identifier and the syntax to specify it. 3) table_identifier in main syntax block and then a sub-syntax in the parameter definition. 4) tableIdentifier in main syntax block and then a sub-syntax in the parameter definition. We can pick one from above 4 or pick a new way as you mentioned. For partitioning spec we have used the following variations. 1) [ PARTITION ( partition_col_name = partition_col_val [ , ... ] ) ] in main syntax block and define the same as a parameter as well. 2) [PARTITION(partition_spec)] in main syntax block and define the same as a parameter. However we have not specified the syntax of the partitioning spec. 3) PARTITION partition_spec in main syntax block. And define "partition_spec" as parameter. In this case also we have not specified the syntax of the partitioning spec. 4) [PARTITION partition_spec] in main syntax block and PARTITION ( partition_spec :[ partition_column = partition_col_value, partition_column = partition_col_value, ...] ) in parameter. 5) partition_spec in main syntax block. And in the parameter section, a sub syntax that defines the syntax of partitioning. Again we can pick one of the above 5 or pick another option. cc @srowen @huaxingao
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
