srowen commented on issue #26655: [SPARK-29293][BUILD] Update scalafmt plugin 
to 1.0.2 for compatibility with Scala 2.13
URL: https://github.com/apache/spark/pull/26655#issuecomment-557957074
 
 
   The plugin changes the parameters used to skip formatting, so it failed 
because it tried to run scalafmt. That is easy enough to fix, both in fixing 
the parameter and also moving to `pluginManagement`; it shouldn't actually be 
used by default by the build.
   
   But, this highlights another problem: scalafmt / plugin doesn't seem to work 
on the complex Spark code at this point: 
https://scalameta.org/scalafmt/docs/known-issues.html#deeply-nested-code . It 
will fail if you run it with the script. 
   
   So I'm also wondering whether we just yank this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to