Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/4394#discussion_r24303675
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -454,6 +455,30 @@ object PushPredicateThroughProject extends
Rule[LogicalPlan] {
}
/**
+ * Push [[Filter]] operators through [[Generate]] operators. Part of the
predicate which referenced
+ * attributes generated in [[Generate]] will remain above, and the rest
should be pushed beneath.
+ */
+object PushPredicateThroughGenerate extends Rule[LogicalPlan] with
PredicateHelper {
+
+ def apply(plan: LogicalPlan): LogicalPlan = plan transform {
+ case filter @ Filter(condition,
+ generate @ Generate(generator, join, outer, alias, grandChild)) =>
+ // Those conjuncts referenced a attributes generated in `generate`
can not
+ // be pushed below `generate`
--- End diff --
Nit: "Predicates that reference attributes produced by the `Generate`
operator cannot be pushed below the operator."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]