srowen commented on a change in pull request #26655: [SPARK-29293][BUILD]
Update scalafmt plugin to 1.0.2 for compatibility with Scala 2.13
URL: https://github.com/apache/spark/pull/26655#discussion_r349976084
##########
File path: pom.xml
##########
@@ -166,7 +166,6 @@
<commons.collections.version>3.2.2</commons.collections.version>
<scala.version>2.12.10</scala.version>
<scala.binary.version>2.12</scala.binary.version>
- <scalafmt.parameters>--diff --test</scalafmt.parameters>
Review comment:
Well, the plugin more than scalafmt. We could pursue a workaround, but maybe
not worth it; I'm not sure how much this is used.
Really, the current state of this PR isn't great, as it no longer does
anything useful. I'll need to either delete it or revert and move it behind a
Scala 2.12 profile. Any opinion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
