cloud-fan commented on a change in pull request #26649: [SPARK-29862][SQL]
CREATE (OR REPLACE) ... VIEW should look up catalog/table like v2 commands
URL: https://github.com/apache/spark/pull/26649#discussion_r349986958
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -3227,6 +3227,60 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
Option(ctx.partitionSpec).map(visitNonOptionalPartitionSpec))
}
+ /**
+ * Create or replace a view. This creates a [[CreateViewStatement]]
+ *
+ * For example:
+ * {{{
+ * CREATE [OR REPLACE] [[GLOBAL] TEMPORARY] VIEW [IF NOT EXISTS]
multi_part_name
+ * [(column_name [COMMENT column_comment], ...) ]
+ * create_view_clauses
+ *
+ * AS SELECT ...;
+ *
+ * create_view_clauses (order insensitive):
+ * [COMMENT view_comment]
+ * [TBLPROPERTIES (property_name = property_value, ...)]
+ * }}}
+ */
+ override def visitCreateView(ctx: CreateViewContext): LogicalPlan =
withOrigin(ctx) {
+ if (!ctx.identifierList.isEmpty) {
+ operationNotAllowed("CREATE VIEW ... PARTITIONED ON", ctx)
+ }
+
+ checkDuplicateClauses(ctx.COMMENT, "COMMENT", ctx)
+ checkDuplicateClauses(ctx.PARTITIONED, "PARTITIONED ON", ctx)
+ checkDuplicateClauses(ctx.TBLPROPERTIES, "TBLPROPERTIES", ctx)
+
+ val userSpecifiedColumns = Option(ctx.identifierCommentList).toSeq.flatMap
{ icl =>
+ icl.identifierComment.asScala.map { ic =>
+ ic.identifier.getText -> Option(ic.STRING).map(string)
+ }
+ }
+
+ val persistedView: Int = 1
+ val globalTempView: Int = 2
+ val localTempView: Int = 3
+ val viewType = if (ctx.TEMPORARY == null) {
+ persistedView
+ } else if (ctx.GLOBAL != null) {
+ globalTempView
+ } else {
+ localTempView
+ }
Review comment:
+1 for view.scala
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
