cloud-fan commented on a change in pull request #26617: [SPARK-29979][SQL]Add
basic/reserved property key constants in Table and SupportsNamespaces
URL: https://github.com/apache/spark/pull/26617#discussion_r350015263
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -301,11 +301,11 @@ class ResolveSessionCatalog(
s"The database name is not valid: ${nameParts.quoted}")
}
- val comment =
c.properties.get(CreateNamespaceStatement.COMMENT_PROPERTY_KEY)
- val location =
c.properties.get(CreateNamespaceStatement.LOCATION_PROPERTY_KEY)
+ val comment = c.properties.get(SupportsNamespaces.PROP_COMMENT)
+ val location = c.properties.get(SupportsNamespaces.PROP_LOCATION)
val newProperties = c.properties -
- CreateNamespaceStatement.COMMENT_PROPERTY_KEY -
- CreateNamespaceStatement.LOCATION_PROPERTY_KEY
+ SupportsNamespaces.PROP_COMMENT -
+ SupportsNamespaces.PROP_LOCATION
Review comment:
nit: `-- SupportsNamespaces.RESERVED_PROPERTIES`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
