HeartSaVioR commented on a change in pull request #26632:
[SPARK-29993][SS]Avoid continuous warn log in get record and offset from Kafka
URL: https://github.com/apache/spark/pull/26632#discussion_r350019983
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaDataConsumer.scala
##########
@@ -587,8 +587,11 @@ private[kafka010] class KafkaDataConsumer(
case ut: UninterruptibleThread =>
ut.runUninterruptibly(body)
case _ =>
- logWarning("KafkaDataConsumer is not running in UninterruptibleThread. "
+
- "It may hang when KafkaDataConsumer's methods are interrupted because
of KAFKA-1894")
+ val warned = _consumer.isDefined
Review comment:
It looks less intuitive for me. I'm not sure how much this makes us be
bothered (the message is quite serious one so I'd be even OK if it's a bit
bothering), but if it's really bugging, then I'd add an explicit flag to check
it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
