fuwhu commented on a change in pull request #26617: [SPARK-29979][SQL]Add
basic/reserved property key constants in Table and SupportsNamespaces
URL: https://github.com/apache/spark/pull/26617#discussion_r350026039
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DescribeNamespaceExec.scala
##########
@@ -45,10 +42,12 @@ case class DescribeNamespaceExec(
val metadata = catalog.loadNamespaceMetadata(ns)
rows += toCatalystRow("Namespace Name", ns.last)
- rows += toCatalystRow("Description", metadata.get(COMMENT_TABLE_PROP))
- rows += toCatalystRow("Location", metadata.get(LOCATION_TABLE_PROP))
+ rows += toCatalystRow("Description",
metadata.get(SupportsNamespaces.PROP_COMMENT))
+ rows += toCatalystRow("Location",
metadata.get(SupportsNamespaces.PROP_LOCATION))
Review comment:
you mean show description and location even when extended is false? correct
me if i misunderstand.
It might be a little different. I think the main content of "describe table"
should be schema, taking description and location as extended may be reasonable
(like in hive).
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
