maropu commented on a change in pull request #26656: [SPARK-27986][SQL] Support
ANSI SQL filter clause for aggregate expression.
URL: https://github.com/apache/spark/pull/26656#discussion_r350164140
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
##########
@@ -152,8 +152,9 @@ case class HashAggregateExec(
override def usedInputs: AttributeSet = inputSet
override def supportCodegen: Boolean = {
- // ImperativeAggregate is not supported right now
-
!aggregateExpressions.exists(_.aggregateFunction.isInstanceOf[ImperativeAggregate])
+ // ImperativeAggregate and filter predicate are not supported right now
Review comment:
Filed: https://issues.apache.org/jira/browse/SPARK-30027
Can you leave some comments about this here like `TODO: SPARK-30027 Support
codegen for filter exprs in HashAggregateExec`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
