maropu commented on a change in pull request #26656: [SPARK-27986][SQL] Support ANSI SQL filter clause for aggregate expression URL: https://github.com/apache/spark/pull/26656#discussion_r350168291
########## File path: sql/core/src/test/resources/sql-tests/inputs/group-by-filter.sql ########## @@ -0,0 +1,29 @@ +-- Test filter clause for aggregate expression. + +-- Test data. +CREATE OR REPLACE TEMPORARY VIEW testData AS SELECT * FROM VALUES Review comment: Can you write most of tests for this pr here where possible? If you cannot, plz use `SQLQuerySuite` instead. (Currently, I think some tests are overlapped between `group-by-filter.sql` and `SQLQuerySuite`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
