gaborgsomogyi commented on a change in pull request #26590: [SPARK-29953][SS] Don't clean up source files for FileStreamSource if the files belong to the output of FileStreamSink URL: https://github.com/apache/spark/pull/26590#discussion_r350149070
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSource.scala ########## @@ -267,10 +269,22 @@ class FileStreamSource( val logOffset = FileStreamSourceOffset(end).logOffset sourceCleaner.foreach { cleaner => - val files = metadataLog.get(Some(logOffset), Some(logOffset)).flatMap(_._2) - val validFileEntities = files.filter(_.batchId == logOffset) - logDebug(s"completed file entries: ${validFileEntities.mkString(",")}") - validFileEntities.foreach(cleaner.clean) + sourceHasMetadata match { + case Some(true) if !warnedIgnoringCleanSourceOption => Review comment: Is it possible that it's called more than once? Such case `case _ =>` will win. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org