viirya commented on a change in pull request #26649: [SPARK-29862][SQL] CREATE
(OR REPLACE) ... VIEW should look up catalog/table like v2 commands
URL: https://github.com/apache/spark/pull/26649#discussion_r350384426
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/DDLParserSuite.scala
##########
@@ -1669,6 +1669,105 @@ class DDLParserSuite extends AnalysisTest {
comparePlans(parsed, expected)
}
+ test("create view -- basic") {
+ val v1 = "CREATE VIEW view1 AS SELECT * FROM tab1"
+ val parsed1 = parsePlan(v1)
+
+ val expected1 = CreateViewStatement(
+ Seq("view1"),
+ Seq.empty[(String, Option[String])],
+ None,
+ Map.empty[String, String],
+ Some("SELECT * FROM tab1"),
+ parsePlan("SELECT * FROM tab1"),
+ false,
+ false,
+ PersistedView)
+ comparePlans(parsed1, expected1)
+
+ val v2 = "CREATE VIEW a.b.c AS SELECT * FROM tab1"
+ val parsed2 = parsePlan(v2)
+
+ val expected2 = CreateViewStatement(
+ Seq("a", "b", "c"),
+ Seq.empty[(String, Option[String])],
+ None,
+ Map.empty[String, String],
+ Some("SELECT * FROM tab1"),
+ parsePlan("SELECT * FROM tab1"),
+ false,
+ false,
+ PersistedView)
+ comparePlans(parsed2, expected2)
+ }
+
+ test("create view - full") {
+ val v1 =
+ """
+ |CREATE OR REPLACE VIEW view1
+ |(col1, col3 COMMENT 'hello')
+ |TBLPROPERTIES('prop1Key'="prop1Val")
+ |COMMENT 'BLABLA'
+ |AS SELECT * FROM tab1
+ """.stripMargin
+ val parsed1 = parsePlan(v1)
+ val expected1 = CreateViewStatement(
+ Seq("view1"),
+ Seq("col1" -> None, "col3" -> Some("hello")),
+ Some("BLABLA"),
+ Map("prop1Key" -> "prop1Val"),
+ Some("SELECT * FROM tab1"),
+ parsePlan("SELECT * FROM tab1"),
+ false,
+ true,
+ PersistedView)
+ comparePlans(parsed1, expected1)
+
+ val v2 =
+ """
+ |CREATE OR REPLACE VIEW a.b.c
+ |(col1, col3 COMMENT 'hello')
+ |TBLPROPERTIES('prop1Key'="prop1Val")
+ |COMMENT 'BLABLA'
+ |AS SELECT * FROM tab1
+ """.stripMargin
+ val parsed2 = parsePlan(v2)
+ val expected2 = CreateViewStatement(
+ Seq("a", "b", "c"),
+ Seq("col1" -> None, "col3" -> Some("hello")),
+ Some("BLABLA"),
+ Map("prop1Key" -> "prop1Val"),
+ Some("SELECT * FROM tab1"),
+ parsePlan("SELECT * FROM tab1"),
+ false,
+ true,
+ PersistedView)
Review comment:
these tests are all for PersistedView, can we have few for other view types?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
