dongjoon-hyun commented on a change in pull request #26666: 
[SPARK-30030][INFRA] Use RegexChecker instead of TokenChecker to check `regex`
URL: https://github.com/apache/spark/pull/26666#discussion_r350388967
 
 

 ##########
 File path: scalastyle-config.xml
 ##########
 @@ -258,7 +258,7 @@ This file is divided into 3 sections:
     scala.collection.JavaConverters._ and use .asScala / .asJava 
methods</customMessage>
   </check>
 
-  <check customId="commonslang2" level="error" 
class="org.scalastyle.scalariform.TokenChecker" enabled="true">
+  <check customId="commonslang2" level="error" 
class="org.scalastyle.file.RegexChecker" enabled="true">
 
 Review comment:
   @srowen and @databricks-david-lewis . This was the root cause.
   I'm not sure if there is any change inside `TokenChecker`, but 
`RegexChecker` is better for `org.apache.commons.lang.` since it's not a token.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to