HeartSaVioR commented on issue #26639: [SPARK-29999][SS] Handle FileStreamSink metadata correctly for empty partition URL: https://github.com/apache/spark/pull/26639#issuecomment-558407617 I'm OK with reverting both #23052 and this, and let me come up with another PR (maybe minor PR or reopening the JIRA issue and change the description) which only contains the UT. I guess it's still viable to try to fix the root issue, like the proposal I proposed in https://github.com/apache/spark/pull/26639#issuecomment-558395855 as @zsxwing 's comment applies only when #23052 requires this patch. But for completeness, even we would want to keep #23052, the ideal step would be 1) reverting both -> 2) adding UT -> 3) submitting revised version of #23052 which contains a good approach for streaming sink as well.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
