cloud-fan commented on a change in pull request #26663: [SPARK-30015][Core]
Continuous shuffle block fetching should be disabled by default when the old
fetch protocol is used
URL: https://github.com/apache/spark/pull/26663#discussion_r350604474
##########
File path:
core/src/main/scala/org/apache/spark/network/netty/NettyBlockRpcServer.scala
##########
@@ -56,8 +56,12 @@ class NettyBlockRpcServer(
message match {
case openBlocks: OpenBlocks =>
val blocksNum = openBlocks.blockIds.length
- val blocks = for (i <- (0 until blocksNum).view)
- yield
blockManager.getBlockData(BlockId.apply(openBlocks.blockIds(i)))
+ val blocks = for (i <- (0 until blocksNum).view) yield {
Review comment:
nit: the loop body is long now, maybe
```
val blocks = (0 until blocksNum).map { i =>
...
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
