HeartSaVioR commented on a change in pull request #26671: Revert 
"[SPARK-26081][SPARK-29999]"
URL: https://github.com/apache/spark/pull/26671#discussion_r350793263
 
 

 ##########
 File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/ManifestFileCommitProtocol.scala
 ##########
 @@ -137,14 +139,7 @@ class ManifestFileCommitProtocol(jobId: String, path: 
String)
     if (addedFiles.nonEmpty) {
       val fs = new 
Path(addedFiles.head).getFileSystem(taskContext.getConfiguration)
       val statuses: Seq[SinkFileStatus] =
-        addedFiles.flatMap { f =>
 
 Review comment:
   Thanks for the pointer. That would also break streaming sink if there's 
empty partition then. Ideally it should be fixed for streaming query, but I 
feel its scope is beyond the PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to