Github user sryza commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4168#discussion_r24310281
  
    --- Diff: 
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
    @@ -438,6 +444,7 @@ private[spark] class ExecutorAllocationManager(
         }
     
         override def onTaskStart(taskStart: SparkListenerTaskStart): Unit = {
    +      numRunningTasks += 1
    --- End diff --
    
    Good point.  It doesn't need synchronization because only one thread is 
writing to it, but we should make it volatile.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to