shahidki31 commented on issue #26378: [SPARK-29724][SPARK-29726][WEBUI][SQL] Support JDBC/ODBC tab for HistoryServer WebUI URL: https://github.com/apache/spark/pull/26378#issuecomment-558852948 > LGTM on the rest, but would be helpful if another set of eyes could look on the store updating logic, because I don't fully know how the flushing, making sure that updates are synced etc. works. Thanks @juliuszsompolski . I have slightly refactored the store update logic Ideally in all the listeners, the store logic goes like this, **LiveUI:** update the store whenever an event comes. To prevent frequent updates, if there are frequent events like tasks event, there is a threshold `liveUpdatePeriod`, so that after the threshold + last written time we update the store. **HistoryUI:** Keep all the events data in a hash map and update the store, after the last event occurs,(or during flush). But here, I am also updating when the session closed event, and execution closed event, so that we can remove the map entries.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
