sarutak commented on a change in pull request #26637: [SPARK-29997][WEBUI] Show
job name for empty jobs in WebUI
URL: https://github.com/apache/spark/pull/26637#discussion_r351034579
##########
File path: core/src/main/scala/org/apache/spark/scheduler/StageInfo.scala
##########
@@ -107,4 +107,7 @@ private[spark] object StageInfo {
taskLocalityPreferences,
shuffleDepId)
}
+
+ val INVALID_STAGE_ID = -1
Review comment:
Thanks.
I've noticed there are too many `final`-less `val` declared in objects as a
constant value in the code base...
Exactly, `val` in object should not be overridden but it's not marked as
`final` in byte code level so I'll put `final` modifier just in case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
