LucaCanali commented on a change in pull request #26692:
[SPARK-30060][CORE][SS][DOC] Implement naming convention for Spark metrics
configuration parameters used to enable/disable metrics sources
URL: https://github.com/apache/spark/pull/26692#discussion_r351274940
##########
File path: core/src/main/scala/org/apache/spark/internal/config/Status.scala
##########
@@ -56,7 +56,7 @@ private[spark] object Status {
.createWithDefault(Int.MaxValue)
val APP_STATUS_METRICS_ENABLED =
- ConfigBuilder("spark.app.status.metrics.enabled")
+ ConfigBuilder("spark.metrics.appStatusSource.enabled")
Review comment:
The appStatus source is new in 3.0 [SPARK-25934]
`spark.metrics.static.sources.enabled` parameter is also newly introduced
for Spark 3.0 [SPARK-29654]
The more delicate change in the proposal is about the potential replacement
for `spark.sql.streaming.metricsEnabled`, that is already in use since a while
[SPARK-17731]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
