dongjoon-hyun commented on a change in pull request #26692:
[SPARK-30060][CORE][SS][DOC] Implement naming convention for Spark metrics
configuration parameters used to enable/disable metrics sources
URL: https://github.com/apache/spark/pull/26692#discussion_r351355256
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -1293,7 +1293,7 @@ object SQLConf {
.createWithDefault(true)
val STREAMING_METRICS_ENABLED =
- buildConf("spark.sql.streaming.metricsEnabled")
+ buildConf("spark.metrics.sparkStreamingSource.enabled")
Review comment:
Or, what about renaming together at 3.0? We still can support legacy config
names together, cannot we?
Also, cc @gatorsmile since he suggest renaming.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
