srowen commented on a change in pull request #26693: [SPARK-30061] Writer
should be closed in RateStreamMicroBatchStream
URL: https://github.com/apache/spark/pull/26693#discussion_r351433786
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/RateStreamMicroBatchStream.scala
##########
@@ -67,6 +67,7 @@ class RateStreamMicroBatchStream(
writer.write("v" + VERSION + "\n")
writer.write(metadata.json)
writer.flush
+ writer.close
Review comment:
I think that will close the underlying output stream, and I don't think
that's what this is supposed to do here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
