Github user tgaloppo commented on a diff in the pull request:
https://github.com/apache/spark/pull/4459#discussion_r24326951
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/BLAS.scala ---
@@ -255,6 +255,20 @@ private[spark] object BLAS extends Serializable with
Logging {
}
}
+ // Workaround for SparseVectors.
+ def syr(alpha: Double, x: SparseVector, A: DenseMatrix) {
+ val mA = A.numRows
+ val nA = A.numCols
+ require(mA == nA, s"A is not a square matrix. A: $mA x $nA")
--- End diff --
Hmm. Symmetry is a requirement of the syr() function; what is being
performed is an incomplete check. The old message mismatched the check, but
matched the requirement; perhaps this could be something like "A is not square,
and thus cannot be symmetric" ... or something along that line?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
