viirya commented on issue #26654: [SPARK-30009][CORE][SQL] Support different floating-point Ordering for Scala 2.12 / 2.13 URL: https://github.com/apache/spark/pull/26654#issuecomment-559272133 > hmm, if the codegen and interpreted behavior is already inconsistent now with scala 2.12, it's a serious bug. @viirya @maropu can you take a look? You mean current master? I compared Utils.nanSafeCompareDoubles with DoubleExactNumeric.compare: ``` left: -1.7976931348623157E308, right: NaN, compare(codegen): -1, compare(interpreted): -1 left: NaN, right: -1.7976931348623157E308, compare(codegen): 1, compare(interpreted): 1 left: 1.7976931348623157E308, right: NaN, compare(codegen): -1, compare(interpreted): -1 left: NaN, right: 1.7976931348623157E308, compare(codegen): 1, compare(interpreted): 1 left: NaN, right: NaN, compare(codegen): 0, compare(interpreted): 0 ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
