srowen commented on issue #26654: [SPARK-30009][CORE][SQL] Support different floating-point Ordering for Scala 2.12 / 2.13 URL: https://github.com/apache/spark/pull/26654#issuecomment-559276523 Yeah, that's to be expected; the `compare` functionality hasn't changed. (I think it highlights that `Double.compare` already does what `Utils.nanSafeCompareDoubles` does?) The question I think is whether the definition of `lt`, `lteq`, etc matters to Spark. I mean, we know it behaves differently in the two Scala 2.13 implementations: `IeeeOrdering` follows JVM operators, `TotalOrdering` follows `compare`. I just don't know if their usage in Spark matters at all, like, whether this ever determines how two doubles compare outside of a sorting task.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
