HeartSaVioR commented on issue #26693: [SPARK-30061][SS] Writer should be closed in RateStreamMicroBatchStream URL: https://github.com/apache/spark/pull/26693#issuecomment-559281485 I think the intention is clear on the code comment, though ideally it should be a scaladoc of the methods. https://github.com/apache/spark/blob/9cd174a7c9cc4c6b782a17c7710650d7eb11389f/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala#L93-L102 https://github.com/apache/spark/blob/9cd174a7c9cc4c6b782a17c7710650d7eb11389f/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala#L117-L138 Provided OutputStream should not be closed by intention, and BufferedWriter.close() will break it.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
