xy2953396112 commented on issue #26693: [SPARK-30061][SS] Writer should be closed in RateStreamMicroBatchStream URL: https://github.com/apache/spark/pull/26693#issuecomment-559293764 Thanks,i will update doc later. ---Original--- From: "Jungtaek Lim"<[email protected]> Date: Thu, Nov 28, 2019 08:09 AM To: "apache/spark"<[email protected]>; Cc: "xy2953396112"<[email protected]>;"Author"<[email protected]>; Subject: Re: [apache/spark] [SPARK-30061][SS] Writer should be closed in RateStreamMicroBatchStream (#26693) How about moving the comments as scaladoc of methods in this PR instead? That would explicitly say implementors should not close the given stream when overriding methods. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
