Github user OopsOutOfMemory commented on a diff in the pull request:
https://github.com/apache/spark/pull/4427#discussion_r24334944
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -397,6 +397,13 @@ private[hive] object HiveQl {
protected def extractDbNameTableName(tableNameParts: Node):
(Option[String], String) = {
val (db, tableName) =
tableNameParts.getChildren.map { case Token(part, Nil) =>
cleanIdentifier(part) } match {
+ case Seq(dbNameAndTable) if (dbNameAndTable.split("\\.").length >
2) => {
+ throw new HiveException("Invalid table name " + dbNameAndTable)
+ }
+ case Seq(dbNameAndTable) if (dbNameAndTable.contains(".")) => {
+ val tokens = dbNameAndTable.split("\\.")
+ (Some(tokens(0)), tokens(1))
+ }
--- End diff --
why we need two `case branches`? The two are one thing.
I think one is ok.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
