srowen commented on a change in pull request #26701: [SPARK-29486][SQL][FOLLOWUP] Document the reason to add days field URL: https://github.com/apache/spark/pull/26701#discussion_r351755853
########## File path: common/unsafe/src/main/java/org/apache/spark/unsafe/types/CalendarInterval.java ########## @@ -34,6 +34,11 @@ public final int days; public final long microseconds; + // Previous CalendarInterval has 2 fields: months and microseconds. Here we add one more days Review comment: Previous -> Previously, has -> had Nit: I don't know if it matters to talk about the previous implementation. A note about why days exist is fine. Frankly it might also be worth a note about why months exists at all (they are also not units of time with a constant length, unlike hours, minutes, seconds) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
