HyukjinKwon commented on issue #25248: [SPARK-28152][SQL][2.4] Mapped ShortType to SMALLINT and FloatType to REAL for MsSqlServerDialect URL: https://github.com/apache/spark/pull/25248#issuecomment-559637417 Yeah, it should be reverted .. but I realised that reverting this is also a breaking change comparing to 2.4.5 (if released). If somebody creates a table in Spark 2.4.4, they might get different type in Spark 2.4.5. It might matter in roundtrip (e.g., `spark.schema(...).jdbc(...)`) ... we might need a flag? WDYT guys
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
