gaborgsomogyi commented on a change in pull request #26594: 
[SPARK-29957][TEST][test-java11][test-hadoop3.2] Reset MiniKDC's default 
enctypes to fit jdk8/jdk11
URL: https://github.com/apache/spark/pull/26594#discussion_r352090435
 
 

 ##########
 File path: 
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala
 ##########
 @@ -136,6 +137,20 @@ class KafkaTestUtils(
     kdcConf.setProperty(MiniKdc.DEBUG, "true")
     kdc = new MiniKdc(kdcConf, kdcDir)
     kdc.start()
+    val krb5Conf = Source.fromFile(kdc.getKrb5conf, "UTF-8").getLines()
 
 Review comment:
   Kafka implemented this because it's not using any Hadoop deps. Here we have 
a different situation but I think it's not the scope of this PR. On another 
Jira this can be discussed...
   
   However my previous comment still stands. This can be tested but no tests 
added. I can personally imagine 2 tests (but maybe one have better idea):
   * `s.contains("libdefaults")`
   * `!s.contains("libdefaults")`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to