huaxingao commented on a change in pull request #26717: [SPARK-30077][SQL]
Create TEMPORARY VIEW USING should look up catalog/table like v2 commands
URL: https://github.com/apache/spark/pull/26717#discussion_r352263351
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala
##########
@@ -169,64 +169,6 @@ class SparkSqlAstBuilder(conf: SQLConf) extends
AstBuilder(conf) {
}
}
- /**
- * Create a table, returning a [[CreateTable]] logical plan.
- *
- * This is used to produce CreateTempViewUsing from CREATE TEMPORARY TABLE.
- *
- * TODO: Remove this. It is used because CreateTempViewUsing is not a
Catalyst plan.
- * Either move CreateTempViewUsing into catalyst as a parsed logical plan,
or remove it because
- * it is deprecated.
- */
- override def visitCreateTable(ctx: CreateTableContext): LogicalPlan =
withOrigin(ctx) {
Review comment:
Several tests in ```DDLSuite``` uses this. I changed the tests from
```CREATE TEMPORARY TABLE``` to ```CREATE TEMPORARY VIEW```, so after the
change this is not used at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
