srowen commented on a change in pull request #26712: [SPARK-29883][SQL] Improve
error messages when function name is an alias
URL: https://github.com/apache/spark/pull/26712#discussion_r352292077
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
##########
@@ -118,7 +118,7 @@ class SimpleFunctionRegistry extends FunctionRegistry with
Logging {
throw new AnalysisException(s"undefined function $name")
}
}
- func(children)
+ func(children).setFuncName(name.funcName)
Review comment:
I see. I don't know enough to evaluate the effect of changing nodeName for
all implementations, which seems like a broader change than required, but it
does make some sense. Maybe @liancheng or @yhuai has an opinion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
