xy2953396112 commented on a change in pull request #26693: [MINOR][SS] Note
that writer should not be closed in RateStreamMicroBatchStream.serialize
URL: https://github.com/apache/spark/pull/26693#discussion_r352402911
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/RateStreamMicroBatchStream.scala
##########
@@ -63,6 +63,7 @@ class RateStreamMicroBatchStream(
val metadataLog =
new HDFSMetadataLog[LongOffset](session.get, checkpointLocation) {
override def serialize(metadata: LongOffset, out: OutputStream): Unit
= {
+ // Writer should not close the given stream when overriding methods.
Review comment:
> Can you move this comment into the doc in the method as pointed out?
Such as:
// Writer should not close the given stream when overriding methods.
override def serialize(metadata: LongOffset, out: OutputStream): Unit = {
is ok?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
