HyukjinKwon commented on a change in pull request #26693: [MINOR][SS] Note that
writer should not be closed in RateStreamMicroBatchStream.serialize
URL: https://github.com/apache/spark/pull/26693#discussion_r352404383
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/sources/RateStreamMicroBatchStream.scala
##########
@@ -62,6 +62,7 @@ class RateStreamMicroBatchStream(
val metadataLog =
new HDFSMetadataLog[LongOffset](session.get, checkpointLocation) {
+ // Writer should not close the given stream when overriding methods.
Review comment:
Sorry, I meant to just move this doc to `HDFSMetadataLog`.
@HeartSaVioR, can you pick this commit and open a new PR for scaladocs at
serialize and deserialize, so that we can credit to @xy2953396112 as a
co-author of this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
