HeartSaVioR commented on a change in pull request #26714: [SPARK-25100][CORE]
Fix no registering TaskCommitMessage bug
URL: https://github.com/apache/spark/pull/26714#discussion_r352458641
##########
File path: core/src/test/scala/org/apache/spark/FileSuite.scala
##########
@@ -700,4 +701,38 @@ class FileSuite extends SparkFunSuite with
LocalSparkContext {
assert(collectRDDAndDeleteFileBeforeCompute(true).isEmpty)
}
+
+ test("SPARK-25100: Using KryoSerializer and" +
+ "setting registrationRequired true can lead job failed") {
+ val tempDir = Utils.createTempDir()
+ val inputFile = tempDir.getAbsolutePath + "/input"
Review comment:
I'd rewrite this as
```
val inputFile = new File(tempDir, "input").getAbsolutePath
```
to avoid dealing with path separator - applies on below lines as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
